Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing/discovery screen2 #93

Merged
merged 10 commits into from
Apr 12, 2024
Merged

Testing/discovery screen2 #93

merged 10 commits into from
Apr 12, 2024

Conversation

CassioManuguerra
Copy link
Contributor

PR

Changes

  • Implemented instrumented android tests for the Discovery screen, checking that every composable is correctly created, the buttons work fine, and special actions are correctly displayed.
  • Fixed a bug where going back to Discover duplicated the displayed activities
  • Fixed a typo in ActivityDialog

@CassioManuguerra CassioManuguerra linked an issue Apr 12, 2024 that may be closed by this pull request
Testing the discovery screen by learning Instrumented Android Testing (Supporting hilt) #71
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Andy130604
Andy130604 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@Andy130604 Andy130604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some great job, nice implementing the clear activities list to make sure we always fetch the correct ones.

JeremyHugentobler
JeremyHugentobler approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@JeremyHugentobler JeremyHugentobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on android tests ! The others are comming soon

@CassioManuguerra CassioManuguerra merged commit 2507629 into main Apr 12, 2024
2 checks passed
@CassioManuguerra CassioManuguerra deleted the testing/discoveryScreen2 branch April 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andy130604 Andy130604 Andy130604 approved these changes

@JeremyHugentobler JeremyHugentobler JeremyHugentobler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing the discovery screen by learning Instrumented Android Testing (Supporting hilt)
3 participants
@CassioManuguerra @Andy130604 @JeremyHugentobler