New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update openPMD metadata #118

Merged

MaxThevenet merged 2 commits into LASY-org:development from RemiLehe:fix_openpmd_metadata

Mar 27, 2023

Member

RemiLehe commented Mar 13, 2023

As discussed in #22 the box cell size is actually not (hi-lo)/npoints but (hi-lo)/(npoints-1).

RemiLehe and others added 2 commits

March 13, 2023 10:47


          Update openPMD metadata

4276c49


          [pre-commit.ci] auto fixes from pre-commit.com hooks

c78a919

for more information, see https://pre-commit.ci

MaxThevenet approved these changes

View reviewed changes

Contributor

MaxThevenet left a comment

Thanks for this PR. I agree, let's make it consistent now, and then we can change it if it seems more appropriate.

MaxThevenet merged commit bca6994 into LASY-org:development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet