Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect button #23

Merged
merged 5 commits into from
Jan 23, 2023
Merged

Disconnect button #23

merged 5 commits into from
Jan 23, 2023

Conversation

LBF38
Copy link
Owner

@LBF38 LBF38 commented Jan 21, 2023

Fixes #11

@thomas40510 thomas40510 mentioned this pull request Jan 21, 2023
Closed
@thomas40510
Copy link
Collaborator

Fix of #24 needed before merge.
I will rework a bit the frontend to make it 2 columns more than a stack of cards

thomas40510
thomas40510 requested changes Jan 21, 2023
View reviewed changes
Copy link
Collaborator

@thomas40510 thomas40510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
see prev comment.
g'day,
cdlt

This was linked to issues Jan 23, 2023
frontend - add return arrow to go back / disconnect #11
Closed
Dialog to confirm account deletion #25
Closed
@thomas40510
add deletion confirm modal
2c6e46b 
Press on "delete" button now needs user confirmation.
@thomas40510 thomas40510 self-requested a review January 23, 2023 10:06
thomas40510
thomas40510 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@thomas40510 thomas40510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAS

@thomas40510 thomas40510 merged commit e4910c2 into development Jan 23, 2023
This was referenced Jan 23, 2023
Closed
Closed
@thomas40510 thomas40510 deleted the frontend/disconnect-button branch January 23, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas40510 thomas40510 thomas40510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog to confirm account deletion frontend - add return arrow to go back / disconnect
2 participants
@LBF38 @thomas40510