Skip to content

Commit

Permalink
fix(label): govuk modifier classes no longer overridden (#157)
Browse files Browse the repository at this point in the history
* fix(perf): clean up sass imports more

* Update README.md

* Update README.md

* feat(tag): combine existing tag component with new status tag styles (#143)

* add docs and scss boilerplate

* feat(status-tag): Added status tag component

* wip

* combine tag and status tag components

Co-authored-by: Jaye <joshua.hackett93@gmail.com>

* add colour docs

* add typography docs

* fix links preview

* chore(docs): added missing checkboxes component from the docs (#146)

* Feature/safe preview area (#145)

* wip

* fix(docs): fix overlay z index

* add a previewarea component to fix appearence issues in docs

Co-authored-by: Jaye <joshua.hackett93@gmail.com>

* fix(button): fixed size of secondary button (#149)

* fix(button): fixed size of secondary button

* chore(docs): fixed missing html tag in md code

* chore(docs): improved docs markup (#148)

* removed double spacing from classNames

* prettified the docs

Co-authored-by: Jaye Hackett <jaye.hackett@gmail.com>

* chore(docs): install and document leaflet docs

* Update issue templates

* fix build

* Delete improve-or-modify-an-existing-component.md

* fix(label): govuk label overrides work again (#155)

* fix(chore): fix semantic release config

Co-authored-by: Jaye <joshua.hackett93@gmail.com>
Co-authored-by: Luca Lischetti <luca@sirlisko.com>
  • Loading branch information
3 people committed Apr 1, 2021
1 parent 7f6fc2b commit 07a0310
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 17 deletions.
16 changes: 0 additions & 16 deletions .github/ISSUE_TEMPLATE/improve-or-modify-an-existing-component.md

This file was deleted.

21 changes: 21 additions & 0 deletions lbh/components/lbh-label/_label.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,25 @@
.lbh-label {
@include lbh-label;
}

// copied these over from govuk frontend because i couldn't see any other way to win the specificity battle
// solves: https://github.com/LBHackney-IT/lbh-frontend/issues/147
.govuk-label--xl {
@include govuk-font($size: 48, $weight: bold);
margin-bottom: govuk-spacing(3);
}

.govuk-label--l {
@include govuk-font($size: 36, $weight: bold);
margin-bottom: govuk-spacing(3);
}

.govuk-label--m {
@include govuk-font($size: 24, $weight: bold);
margin-bottom: govuk-spacing(2);
}

.govuk-label--s {
@include govuk-font($size: 19, $weight: bold);
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"@semantic-release/git",
{
"assets": [
"dist/**/*.{js,css}",
"dist",
"package.json",
"CHANGELOG.md"
],
Expand Down

0 comments on commit 07a0310

Please sign in to comment.