Reduce the number of constants #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelmo
approved these changes
Apr 9, 2021
Comment on lines
+9
to
+10
| sampling_keep_iters = 100, | ||
| sampling_size = 1000, |
There was a problem hiding this comment.
This is fine (good size for testing quickly) but not realistic sized, we should put in the docs that the user must make these constants much larger.
There was a problem hiding this comment.
transforming to an issue
| @@ -31,6 +31,6 @@ | |||
| qp_solver_attributes = change_solver_attribute("verbose", false), | |||
| ) | |||
|
|
|||
| @test isapprox(d["PGM"], -17.568590034769613, atol = default_constants.TEST_RELAX_TOL) | |||
| @test isapprox(v[8], -17.568590034769613, atol = default_constants.TEST_RELAX_TOL) # OSQP sucks | |||
There was a problem hiding this comment.
you took away my comment showing disdain for OSQP? :)
There was a problem hiding this comment.
Arwen voice, elf music playing:
🎵 It shall be buried in git history forever. 🎵
🎵 Only those who look deep enough shall find. 🎵
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@laurentheirendt this fixes some of the stuff from review of #78, decided to separate it to keep that clean.