use StableRNGs for initialization #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the tests failing in Julia 1.5 (which changed the default RNG). Assorted extra changes: - initGigaSOM is now seeded using either seed= or explicit rng= parameter - Removed a bit of unnecessary imports - Removed colNames from Som struct - Changed the test reference data to match the StableRNG - dstat() now really returns 1-dim vectors, not single-line matrices
Codecov Report
@@ Coverage Diff @@
## develop #147 +/- ##
===========================================
+ Coverage 89.17% 89.28% +0.11%
===========================================
Files 12 12
Lines 471 476 +5
===========================================
+ Hits 420 425 +5
Misses 51 51
Continue to review full report at Codecov.
|
|
very nice work @exaexa 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the tests failing in Julia 1.5 (which changed the default RNG). Likely closes #132 and #144.
Assorted extra changes:
Extra stuff to decide:
The new initialization uses an approximation of the dataset and avoids some data bias. We can do better (have a covariance matrix computed on the data and make a nice skewed ellipsoid instead of axis-aligned one). If that sounds important, please let me know (cc @oHunewald ); though I guess it has little practical value except perhaps if the data is already flat.