Merge pull request #36 from LD4P/coverage

CI hooks coveralls to jest coverage

.circleci/config.yml

@@ -35,7 +35,7 @@ jobs:
           command: npm run grunt --silent
       - run:
           name: Run jest tests
-          command: npm run jest-ci --silent
+          command: npm run jest-ci
           environment:
             JEST_JUNIT_OUTPUT: "test-results/jest/jest-results.xml"
       - store_test_results:

README.md

@@ -1,4 +1,5 @@
 [![CircleCI](https://circleci.com/gh/LD4P/sinopia_editor.svg?style=svg)](https://circleci.com/gh/LD4P/sinopia_editor)
+[![Coverage Status](https://coveralls.io/repos/github/LD4P/sinopia_editor/badge.svg?branch=master)](https://coveralls.io/github/LD4P/sinopia_editor?branch=master)
 
 [bfe][demo-page]
 =======================

package.json

@@ -21,6 +21,7 @@
     "url": "https://github.com/LD4P/sinopia_editor.git"
   },
   "devDependencies": {
+    "coveralls": "^3.0.2",
     "eslint": "^5.6.0",
     "eslint-plugin-jest": "^21.22.1",
     "eslint-plugin-node": "^7.0.1",
@@ -51,10 +52,10 @@
   },
   "scripts": {
     "grunt": "grunt",
-    "eslint": "node_modules/.bin/eslint --max-warnings 1319 --color -c .eslintrc.js .",
-    "test": "node_modules/.bin/jest --colors",
-    "jest-cov": "node_modules/.bin/jest --coverage --colors",
-    "jest-ci": "node_modules/.bin/jest --ci --runInBand --coverage --reporters=default --reporters=jest-junit --colors"
+    "eslint": "eslint --max-warnings 1319 --color -c .eslintrc.js .",
+    "test": "jest --colors",
+    "jest-cov": "jest --coverage --colors",
+    "jest-ci": "jest --ci --runInBand --coverage --reporters=default --reporters=jest-junit --colors  && cat ./coverage/lcov.info | coveralls"
   },
   "license": "ISC",
   "dependencies": {
@@ -63,6 +64,10 @@
   },
   "jest": {
     "preset": "jest-puppeteer",
+    "collectCoverage": true,
+    "collectCoverageFrom": [
+      "src/**/*.js"
+    ],
     "reporters": [
       "default",
       "jest-junit"

src/bfelookups.js

@@ -132,6 +132,7 @@ bfe.define('src/lookups/lcnames', ['require', 'exports', 'module', 'src/lookups/
       var triple = {};
       triple.s = subjecturi;
       triple.p = property.propertyURI;
+      // selected.uri = selected.uri;  // FIXME: I *think* this line is useless but feel too green to remove it
       triple.o = selected.uri;
       triple.otype = 'uri';
       triples.push(triple);