Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain language after editing InputLiteral #1147

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Retain language after editing InputLiteral #1147

merged 1 commit into from
Aug 2, 2019

Conversation

justinlittman
Copy link
Contributor

closes #1136

Note that this needs to be rebased after #1133 is merged.

@justinlittman justinlittman marked this pull request as ready for review August 2, 2019 17:21
ndushay
ndushay approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I prefer tests to be unordered, we certainly have integration tests now that are ordered, and I'm glad to have this test ...

@justinlittman justinlittman merged commit b117a5b into master Aug 2, 2019
@justinlittman justinlittman deleted the t1136-lang_lost branch August 2, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndushay ndushay ndushay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language lost after editing value
2 participants
@justinlittman @ndushay