Display error for bad prop template #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndushay
commented
Aug 2, 2019
| } else { | ||
| // not sure this error is ever surfaced anywhere, but we do need to trap for undefined resourceTemplate | ||
| // possibly will be surfaced when issue #1148 is addressed | ||
| this.addError(reduxPath, labelPath, `unable to retrieve ${resourceTemplateId} from local store`) |
There was a problem hiding this comment.
needed to add this else block to avoid "resourceTemplate undefined" error, which wasn't even being trapped for.
ndushay
force-pushed
the
display-error-for-bad-prop-template
branch
from
7dfb0f8
to
8136aae
Compare
jermnelson
requested changes
Aug 2, 2019
jermnelson
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1122.
Before
note no display of error except in console ... (you can tell I clicked the Add button because it's darker blue ...)
After