PropertyComponent: display textFieldType error case to user

__tests__/__fixtures__/lookupWithValueTemplateRefs.json

@@ -0,0 +1,40 @@
+{
+  "id": "Sinopia:RT:Fixture:LookupWithValueTemplateRefs",
+  "resourceURI": "http://examples.org/bogusOntologies/Resource",
+  "remark": "This is a sample Resource Template, content is meaningless",
+  "resourceLabel": "test lookup type misconfigured with valueTemplateRefs",
+  "author": "surrogate for Nancy Lorimer",
+  "schema": "https://ld4p.github.io/sinopia/schemas/0.0.9/resource-template.json",
+  "propertyTemplates": [
+    {
+      "mandatory": "false",
+      "repeatable": "true",
+      "type": "lookup",
+      "valueConstraint": {
+        "defaults": [],
+        "useValuesFrom": [],
+        "valueDataType": {},
+        "valueTemplateRefs": [
+          "resourceTemplate:bf2:Note"
+        ]
+      },
+      "propertyLabel": "lookup type with valueTemplateRefs",
+      "propertyURI": "http://examples.org/bogusOntologies/lookup1"
+    },
+    {
+      "mandatory": "false",
+      "repeatable": "true",
+      "type": "resource",
+      "valueConstraint": {
+        "defaults": [],
+        "useValuesFrom": [],
+        "valueDataType": {},
+        "valueTemplateRefs": [
+          "resourceTemplate:bf2:Title:Note"
+        ]
+      },
+      "propertyLabel": "resource type with valueTemplateRefs",
+      "propertyURI": "http://examples.org/bogusOntologies/lookup2"
+    }
+  ]
+}

__tests__/fixtureLoaderHelper.js

@@ -53,6 +53,7 @@ const rtFileNames = [
   'literalRepeatDefaultLiteralNonEnglish.json',
   'literalRepeatDefaultLiteralOnly.json',
   'literalRepeatNoDefault.json',
+  'lookupWithValueTemplateRefs.json',
   'propertyURIRepeated.json',
   'rdaItemMonograph.json',
 ]

__tests__/integration/propertyTemplateMisconfigured.test.js

@@ -0,0 +1,22 @@
+// Copyright 2019 Stanford University see LICENSE for license
+
+import pupExpect from 'expect-puppeteer'
+import { testUserLogin } from './loginHelper'
+
+describe('Errors with Misconfigured Property Templates', () => {
+  beforeAll(async () => {
+    await testUserLogin()
+  })
+
+  beforeEach(async () => {
+    await page.goto('http://127.0.0.1:8888/templates')
+    await page.waitForSelector('.react-bootstrap-table')
+  })
+
+  it('lookup type misconfigured with valueTemplateRefs', async () => {
+    // expect.assertions(3)
+    await pupExpect(page).toClick('a[href="/editor"]', { text: 'test lookup type misconfigured with valueTemplateRefs' })
+    await pupExpect(page).toClick('button.btn-add[data-id="lookup1"]')
+    await pupExpect(page).toMatch('This propertyTemplate should not be of type lookup.')
+  })
+})

src/components/editor/property/PropertyComponent.jsx

@@ -10,6 +10,19 @@ import { getTagNameForPropertyTemplate } from 'utilities/propertyTemplates'
 
 const PropertyComponent = (props) => {
   const tag = getTagNameForPropertyTemplate(props.propertyTemplate)
+  if (!tag) {
+    return (
+      <div className="row">
+        <div className="col-md-12" style={{ marginTop: '10px' }}>
+          <div className="alert alert-danger alert-dismissible">
+            <button className="close" data-dismiss="alert" aria-label="close">&times;</button>
+            This propertyTemplate should not be of type {props.propertyTemplate.type}.
+          </div>
+        </div>
+      </div>
+    )
+  }
+
   const TagName = React.lazy(() => import(`./${tag}`))
   return (
     <React.Suspense fallback={<div>Loading...</div>}>

src/utilities/propertyTemplates.js

@@ -32,7 +32,7 @@ const textFieldType = (config, propertyTemplate) => {
     case 'resource':
       return 'InputURI'
     default:
-      console.error(`Unknown propertyTemplate type (component=${config}, type=${propertyTemplate.type})`)
+      // error case handled by caller
       return null
   }
 }