Display error when retrieving resource and refactors load and save actions. #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlittman
force-pushed
the
t1447-load_errors
branch
from
24e046c
to
d13dd8a
Compare
jcoyne
approved these changes
Oct 9, 2019
jcoyne
reviewed
Oct 9, 2019
| LANGUAGE_SELECTED: setMyItemsLang, | ||
| SHOW_RDF_PREVIEW: showRdfPreview, | ||
| LANGUAGES_RECEIVED: languagesReceived, | ||
| LOADING_LANGUAGES: loadingLanguages, |
There was a problem hiding this comment.
I wonder if we should change these to RETRIEVE_LANGUAGES_STARTED/FINISHED for consistency.
jcoyne
requested changes
Oct 9, 2019
| @@ -26,7 +26,7 @@ describe('fetchResourceTemplate', () => { | |||
| await fetchResourceTemplate(resourceTemplateId, dispatch) | |||
| expect(dispatch).toBeCalledWith({ type: 'RETRIEVE_RESOURCE_TEMPLATE_STARTED', payload: resourceTemplateId }) | |||
| expect(dispatch).toBeCalledWith({ | |||
| type: 'RETRIEVE_ERROR', | |||
| type: 'SET_RETRIEVE_RESOURCE_TEMPLATE_ERROR', | |||
There was a problem hiding this comment.
I don't like SET_* for events. The events should say what happened, not how to handle it. I prefer RETRIEVE_RESOURCE_TEMPLATE_ERROR for this.
src/actions/index.js
Outdated
| type: 'APPEND_RESOURCE', | ||
| payload: { reduxPath, resource, resourceTemplates }, | ||
| export const setResourceTemplate = resourceTemplate => ({ | ||
| type: 'SET_RESOURCE_TEMPLATE', |
There was a problem hiding this comment.
Maybe RESOURCE_TEMPLATE_LOADED? Not SET_
src/actions/index.js
Outdated
| type: 'TOGGLE_COLLAPSE', | ||
| payload: { reduxPath }, | ||
| export const setResourceTemplateSummary = resourceTemplateSummary => ({ | ||
| type: 'SET_RESOURCE_TEMPLATE_SUMMARY', |
There was a problem hiding this comment.
Maybe RESOURCE_TEMPLATE_SUMMARY_LOADED? Not SET_
src/actions/index.js
Outdated
| export const clearSearchResults = () => ({ | ||
| type: 'CLEAR_SEARCH_RESULTS', | ||
| export const setSaveResourceTemplateError = (resourceTemplateId, reason) => ({ | ||
| type: 'SET_SAVE_RESOURCE_TEMPLATE_ERROR', |
There was a problem hiding this comment.
SAVE_RESOURCE_TEMPLATE_ERROR not SET_
src/actions/index.js
Outdated
| export const clearResourceTemplates = () => ({ | ||
| type: 'CLEAR_RESOURCE_TEMPLATES', | ||
| export const setSaveResourceError = (uri, reason) => ({ | ||
| type: 'SET_SAVE_RESOURCE_ERROR', |
There was a problem hiding this comment.
SAVE_RESOURCE_ERROR not SET_
… Refactors save/load resource/resource template actions for consistency. closes #1447
justinlittman
force-pushed
the
t1447-load_errors
branch
from
d13dd8a
to
abc10ae
Compare
|
Various renaming completed @jcoyne . |
jcoyne
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.