Prevent upload modal & flash message from showing stale messages #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jermnelson
reviewed
May 23, 2019
jermnelson
requested changes
May 23, 2019
ndushay
requested changes
May 23, 2019
| this.setState(newState) | ||
| } | ||
|
|
||
| // Returns a URL or an empty string | ||
| humanReadableLocation = response => { |
|
If you're in a rush to merge, I can change to "approve" but I think the cleanup would help readability of tests and code. |
Fixes #534 This branch includes the following changes: * Reset messages and errors in `ImportResourceTemplate` component when HTTP response is successful * Reset messages when update handler is finished * Prevent users from dismissing flash message box, else it never comes back * Extract code to parse a response object into a human-friendly location into a new function in `ImportResourceTemplate` component * Add Babel plugin for optional chaining (as dev dependency) via the safe navigation (or "Elvis") operator * This lets us safely reach into objects such as HTTP responses without having to check at every level for `null` or `undefined`
mjgiarlo
force-pushed
the
refresh_rt_flash_messages_534
branch
from
96566df
to
afc9e90
Compare
jermnelson
approved these changes
May 23, 2019
ndushay
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #534
This branch includes the following changes:
ImportResourceTemplatecomponent when HTTP response is successfulImportResourceTemplatecomponentnullorundefined