Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strangeness with warning and confirmation messages on RT upload #534

Closed
michelleif opened this issue May 18, 2019 · 0 comments · Fixed by #550
Closed

strangeness with warning and confirmation messages on RT upload #534

michelleif opened this issue May 18, 2019 · 0 comments · Fixed by #550
Assignees
Labels
bug Something isn't working

Comments

@michelleif
Copy link
Contributor

michelleif commented May 18, 2019

tested in DEV with Firefox with Profiles containing only one RT each

  1. attempt to upload existing template friday5, get warning as expected "friday5 already exists. Do you want to overwrite these resource templates?", choose "Yes, overwrite", get blue message as expected "Attempting to update, Updated". Everything works so far.
  2. try to upload another RT which is called friday5, but which has some internal changes (resource and property label). get message "friday5 already exists, friday5 already exists" as if the message from testing suite for sinopia_editor  #1 didn't get cleared. choose "yes overwrite", blue message is "Attempting to update , Updated , Attempting to update , Unexpected response (500)! , Updated" again as if the message from testing suite for sinopia_editor  #1 is still there (and don't know what the 500 error is but the revised RT was successfully uploaded and the old one overwritten). (I checked that the Resource label was updated as per the new version, and opened the RT to make sure the new property label was showing and both those things worked fine.)
  3. now I close the blue message (with the little x) to see if the next time I do it, I will get a fresh confirmation message. but now the blue message doesn't appear at al when I try to upload a new or revised resource template (though the new or revised does seem to upload successfully). If I click away from that tab and then back, the blue message comes back the next time I upload, and the blue message is "refreshed", i.e., it doesn't have any of the old confirmation messages.

basically if I keep trying to upload existing Resource Templates, the overwrite warning keeps getting longer and longer, like this (this is on the 3rd time uploading a saturday2 template)
Screen Shot 2019-05-18 at 8 56 33 AM

and the blue confirm message keeps getting longer and longer, like:
Screen Shot 2019-05-18 at 8 56 43 AM

@michelleif michelleif added bug Something isn't working M3 labels May 18, 2019
@mjgiarlo mjgiarlo self-assigned this May 22, 2019
mjgiarlo added a commit that referenced this issue May 23, 2019
Fixes #534

This branch includes the following changes:
* Reset messages and errors in `ImportResourceTemplate` component when HTTP response is successful
* Reset messages when update handler is finished
* Prevent users from dismissing flash message box, else it never comes back
* Extract code to parse a response object into a human-friendly location into a new function in `ImportResourceTemplate` component
* Add Babel plugin for optional chaining (as dev dependency) via the safe navigation (or "Elvis") operator
  * This lets us safely reach into objects such as HTTP responses without having to check at every level for `null` or `undefined`
mjgiarlo added a commit that referenced this issue May 23, 2019
Fixes #534

This branch includes the following changes:
* Reset messages and errors in `ImportResourceTemplate` component when HTTP response is successful
* Reset messages when update handler is finished
* Prevent users from dismissing flash message box, else it never comes back
* Extract code to parse a response object into a human-friendly location into a new function in `ImportResourceTemplate` component
* Add Babel plugin for optional chaining (as dev dependency) via the safe navigation (or "Elvis") operator
  * This lets us safely reach into objects such as HTTP responses without having to check at every level for `null` or `undefined`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants