Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display validations at the top level when validate is pressed. #717

Merged
merged 1 commit into from Jun 14, 2019

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jun 13, 2019

Ref #311 #303

@jcoyne jcoyne force-pushed the validate-state branch 2 times, most recently from d75d5e5 to 7e36c9a Compare June 13, 2019 22:04
Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Only crucial thing, IMO, is to make a ticket for your TODO comment.

__tests__/Validator.test.js Outdated Show resolved Hide resolved
src/Validator.js Outdated Show resolved Hide resolved

/**
* Check and see if this property is required and if so, if it's filled in.
* @return {Array} a list of errors for the property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or empty array if no errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a list of 0 errors.

@jcoyne
Copy link
Contributor Author

jcoyne commented Jun 14, 2019

@ndushay changes made.

Sinopia Work-Cycle One automation moved this from Needs Review to In Progress Jun 14, 2019
@jermnelson jermnelson merged commit 667b4ea into master Jun 14, 2019
Sinopia Work-Cycle One automation moved this from In Progress to Done Jun 14, 2019
@jermnelson jermnelson deleted the validate-state branch June 14, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants