Use Utility function in InputLiteral component to determine the boolean values from JSON strings #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #738 to be merged |
|
@jgreben In which situations would the props have null formData? |
jgreben
force-pushed
the
undefined-literal-items
branch
from
145a523
to
6f44bd4
Compare
jgreben
force-pushed
the
undefined-literal-items
branch
from
6f44bd4
to
dd8cd25
Compare
jgreben
changed the title
ndushay
approved these changes
Jun 17, 2019
| @@ -118,13 +119,13 @@ export class InputLiteral extends Component { | |||
| this.inputLiteralRef.current.focus() | |||
| } | |||
|
|
|||
| /** | |||
| * @return {bool} true if the field should be marked as required (e.g. not all obligations met) | |||
There was a problem hiding this comment.
say default is false? or is that obvious?
There was a problem hiding this comment.
I think it's pretty clear from how it's documented that if it doesn't meet that condition it's false.
jcoyne
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #738 Fixed #736. This PR is now only about using the Utility function to determine the boolean values from JSON strings.