Clear validation errors when a resource template is loaded #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Jun 20, 2019
| // This assertion adds 1 to each it blocks assertion count | ||
| await pupExpect(page).toClick('a', { text: 'BIBFRAME Instance' }) | ||
|
|
||
| // Click on one of the property type rows to expand a nested resource |
There was a problem hiding this comment.
do we need the rest of this function?
There was a problem hiding this comment.
Oh yeah, probably not. That's just how I was manually testing it. Will update.
There was a problem hiding this comment.
Done. Good catch.
ndushay
reviewed
Jun 20, 2019
| @@ -27,3 +27,8 @@ export async function fillInRequredFieldsForBibframeInstance() { | |||
| await page.waitForSelector('#rbt-menu-item-0') | |||
| await page.click('#rbt-menu-item-0') | |||
| } | |||
|
|
|||
| export async function incompleteFieldsForBibframeInstance() { | |||
| // This assertion adds 1 to each it blocks assertion count | |||
There was a problem hiding this comment.
PR looks fine but I don't understand this comment.
There was a problem hiding this comment.
I'm not great and clarifying this, but this is the assertion that means any block "it" block that includes this call needs to check for it's assertions+1.
There was a problem hiding this comment.
ah! how about
// this assertion adds 1 to each "it" block's expect.assertion(n) count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #745
Clears the errors and sets displayValidations to false when a resource template is loaded. Adds unit testing for the values and an integration test for displaying and clearing the validation errors on the page.
Before: After validation errors and clicking on a new template - Validation errors are still displayed.
After: After validation errors and clicking on a new template - Validation errors are cleared.