Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker-compose and Dockerfiles for production #15

Closed
wants to merge 3 commits into from

Conversation

KillianKemps
Copy link

@KillianKemps KillianKemps commented Feb 12, 2018

Hello,

There is already a Pull Request for a Docker Compose for development purpose #12 but here is one used for production purpose.

Everything is automated from creating containers to setting up the database. A simple docker-compose up does everything and gives a running website : front-end, back-end and database.

However, you still have to add the back-end URL on the front-end interface as we don't see a way to automate it.

We include the Dockerfiles so you can build the images yourself. The docker-compose.yml is here for demonstration purpose. You may want to use Docker with Kubernetes for example for production.

Maybe this repository is not well suited for a Docker configuration, we could imagine having a special repository pia-docker ?

Or maybe add a Docker build step to your release process?

@kosmas58
Copy link
Contributor

Hello Killian,

thanks for your awesome Docker configuration. It tested it and it works fine.

Not every DPO is able to setup the PIA application stack. With your configuration it is much easier now. As you suggested, I've created a pia-docker repository containing your files. I will add some additional information, so people should be able to setup PIA.

I don't want to appropriate your work. So it's up to you to contact LNIC for the creation of pia-docker repository.

Best regards,
Kosmas

@KillianKemps
Copy link
Author

Hello @kosmas58,

Thank you for your comment, I'm happy you could use the Docker configuration.
I checked your pia-docker repository and it seems fine. I see no issue if the LNIC uses your repository for building Docker images.

I have just updated the Dockerfiles in my Pull Request for the latest 1.6.0 release of the app if you want to update on your side too. :)

Could someone from @LaboCNIL give an input what would be possible and convenient for the LNIC?

@kosmas58
Copy link
Contributor

kosmas58 commented Mar 3, 2018

Hello Killian,

thanks for your comment. I merged your changes into branch 1.6.0. I'd open an issue #21 on pia-back. I hope LaboCNIL will accept the repository. Probably both of us can maintain it.

Cheers,
Kosmas

@brunto
Copy link
Collaborator

brunto commented Jan 7, 2019

Duplicate, you can check the docker repo here: https://github.com/kosmas58/pia-docker

@brunto brunto closed this Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants