-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rubocop, brakeman, bundler-audit #236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
035843e
to
2da4eb2
Compare
@syl-p LINT to fix |
432e7c8
to
c84d3a7
Compare
c84d3a7
to
4be0e08
Compare
Three old Rails default framework files (5.2, 6.0, 7.0) have been deleted. The Rails default version has been upgraded from 5.0 to 7.0 in the application configuration. Various modifications have also been made across the test files to consistently use FactoryBot for object creation.
Added the nokogiri dependency for the x86_64-linux platform in the Gemfile.lock. This update ensures that the application will run smoothly on both the arm64-darwin-23 and the newly added x86_64-linux platforms.
Environment variables `RAILS_ENV` and `DATABASE_URL` are now set earlier in the GitHub Actions workflow. This change provides better organization and makes sure that necessary variables are set before running the subsequent tasks.
brunto
previously approved these changes
Jan 24, 2024
kevin-atnos
previously approved these changes
Jan 24, 2024
The versions of Ruby and Bundler used in the project have been updated. Our Ruby version has been updated from 3.1.4p223 to 3.3.0p0 and Bundler is now set to 2.5.3. This will ensure compatibility with the latest updates and features.
Note :
|
kevin-atnos
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.