Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sessionSigs and validators where needed #54

Merged
merged 9 commits into from
Mar 29, 2023
Merged

added sessionSigs and validators where needed #54

merged 9 commits into from
Mar 29, 2023

Conversation

glitch003
Copy link
Collaborator

No description provided.

DashKash54
DashKash54 reviewed Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@DashKash54 DashKash54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a comment. There are a few places where the sessionSigs are still missing. I'll add a commit to this PR addressing that.

packages/encryption/src/lib/params-validators.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a check for the case when both the authSig & sessionSigs are provided?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this: feat: Validate if only either authSig or sessionSigs are provided

packages/misc/src/lib/misc.ts Show resolved Hide resolved
@DashKash54
Copy link
Collaborator

Hi @glitch003 there's an error with the saveEncryptionKey function. I tried using it in a local app & it threw the error for safeParams: https://github.com/LIT-Protocol/js-sdk/blob/fix/either-auth-sig-or-session-sig-required/packages/encryption/src/lib/params-validators.ts#L243
Also the nodes are throwing an error that the authSig isn't recognized.
I'm working on its fix

@Ansonhkg
Copy link
Collaborator

added a little tool to check if the built package dependencies matches the package version. This does not affect the current workflow.

yarn build:verify

Ansonhkg added a commit that referenced this pull request Mar 27, 2023
@Ansonhkg
merge: #54
20689d8
@Ansonhkg
Copy link
Collaborator

@Adarsh-Kumar28 we can merge this

@DashKash54 DashKash54 merged commit bad6268 into master Mar 29, 2023
@DashKash54 DashKash54 mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DashKash54 DashKash54 DashKash54 left review comments

@Ansonhkg Ansonhkg Awaiting requested review from Ansonhkg Ansonhkg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glitch003 @DashKash54 @Ansonhkg