Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthSig + getSessionSigs Description Updates #571

Merged
merged 12 commits into from
Aug 19, 2024

Conversation

awisniew207
Copy link
Contributor

Added:
AuthSig properties explanation
getSessionSigs return explanation
Additional getSessionSigs properties explanation

Comments always welcome!

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2024

CLA assistant check
All committers have signed the CLA.

@Ansonhkg Ansonhkg added the documentation Improvements or additions to documentation label Aug 1, 2024
@awisniew207
Copy link
Contributor Author

Not sure why the most recent e2e test failed. I only changed a couple comments, looks like the testExecuteJsSignAndCombineEcdsa test failed

packages/types/src/lib/interfaces.ts Outdated Show resolved Hide resolved
packages/types/src/lib/interfaces.ts Outdated Show resolved Hide resolved
packages/types/src/lib/interfaces.ts Outdated Show resolved Hide resolved
packages/types/src/lib/interfaces.ts Outdated Show resolved Hide resolved
packages/types/src/lib/interfaces.ts Outdated Show resolved Hide resolved
packages/types/src/lib/interfaces.ts Outdated Show resolved Hide resolved
@joshLong145 joshLong145 self-requested a review August 12, 2024 17:17
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ansonhkg Ansonhkg merged commit 36a4ad6 into master Aug 19, 2024
4 checks passed
@Ansonhkg Ansonhkg deleted the andrew/session-auth-sig-update branch August 19, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants