Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Deflake LoopTest.WaitOneBlocking by increasing timeout. (iree-org#17857)
This test case has failed a few times on macos_x86, and possibly on other platforms too. I suspect the OS isn't scheduling the test threads soon enough - there's only a 150 millisecond window between the event set on a worker thread and `iree_loop_wait_one`'s timeout on the main thread: ``` main thread worker thread ----------- ------------- test start spin up thread ------> wait 50ms wait 200ms ... ... <------ set event timeout if event not set ``` Sample logs: * https://github.com/iree-org/iree/actions/runs/9214985535/job/25352380335#step:10:1578 * https://github.com/iree-org/iree/actions/runs/9882364677/job/27295096340?pr=17856#step:9:43 ``` [ RUN ] LoopTest.WaitOneBlocking iree/runtime/src/iree/base/loop_test.h:612: Failure Value of: status Expected: error code OK Actual: 0x4, whose error code is DEADLINE_EXCEEDED: DEADLINE_EXCEEDED [ FAILED ] LoopTest.WaitOneBlocking (200 ms) ``` We could also use an infinite timeout. Signed-off-by: Lubo Litchev <lubol@google.com>
- Loading branch information