Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix h5repack test #107

Merged
merged 2 commits into from
Mar 4, 2023
Merged

Fix h5repack test #107

merged 2 commits into from
Mar 4, 2023

Conversation

markcmiller86
Copy link
Member

@markcmiller86 markcmiller86 commented Mar 3, 2023 •
edited

This fixes h5repack test for any endian machine.

Resolves #100

  • Adds -n (use native types) to h5repack
  • Uses output from print_h5repack_farg to generate argument to h5repack test
  • Add logic to disallow and print error message if using relative paths for ZFP_HOME or HDF5_HOME in vanilla gnu make builds

@markcmiller86 markcmiller86 mentioned this pull request Mar 3, 2023
Closed
@markcmiller86 markcmiller86 merged commit 1660d94 into master Mar 4, 2023
@markcmiller86 markcmiller86 deleted the mcm86-02mar23-h5repack-big-endian branch March 4, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brtnfld brtnfld Awaiting requested review from brtnfld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-h5repack fails on big endian architectures
1 participant
@markcmiller86