Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CMake testing #110

Closed
wants to merge 9 commits into from
Closed

Enable CMake testing #110

wants to merge 9 commits into from

Conversation

brtnfld
Copy link
Collaborator

@brtnfld brtnfld commented Apr 4, 2023

Enable CMake testing:

  • Convert Linux shell tests to Powershell to work on windows
  • Fix tests to build on windows
  • Fix tests to pass on windows
  • Enable github actions to run CMake tests on Linux
  • Enable github actions to run CMake tests on Windows
  • Verify the CMake tests cover the same as Autotool's tests

jwsblokland and others added 8 commits August 26, 2022 12:14
- Bug fix in the specification of the target_include_directories
  such it can find the created Fortran module file.
- Implemented the option to specify the output file of the
  Fortran test program.
- Implemented several tests for both the plugin as well as for
  for the library. The tests themselves are based on the existing
  Make tests.
- Implemented the proper logic for the cfp test. Be aware, this
  logic requires a recent update of ZFP library in which the
  cfp target is exposed by the ZFP CMake configuration file.
Addressed Windows warnings and compiling issues
- Define _GNU_SOURCE only if it is not defined yet.
- Properly support building of the library and plugin using
  Microsoft Visual Studio.
- Exclude certain tests when the compiler corresponds to some
  version of Microsoft Visual Compiler.
@lrknox
Copy link

lrknox commented Apr 11, 2023

After setting HDF5_DIR and ZFP_DIR, creating a build subdirectory and running "CC=gcc FC=gfortran cmake -DCMAKE_INSTALL_PREFIX=/mnt/wrk/lrknox/h5z-zfp_install .." in the build directory (which succeeds), running either "make install" or running "cmake --build . --config Release" produced the following error:

[100%] Linking C executable print_h5repack_farg
/usr/bin/ld: CMakeFiles/test_write_plugin.dir/test_write.c.o: undefined reference to symbol 'exp@@GLIBC_2.2.5'
//usr/lib64/libm.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
gmake[2]: *** [test/test_write_plugin] Error 1
gmake[1]: *** [test/CMakeFiles/test_write_plugin.dir/all] Error 2

This was with CMake 3.22.1 and GCC 10.2.0 modules on centOS7 (jelly).

@brtnfld
Copy link
Collaborator Author

brtnfld commented Apr 11, 2023

Probably need to add ${CMAKE_DL_LIBS} to target_link_libraries()

@brtnfld brtnfld added this to the 1.1.1 milestone Apr 11, 2023
@markcmiller86
Copy link
Member

Ok, am returning my attention to this for a week. Where are we at with this? Is it still a work in progress?

@lrknox
Copy link

lrknox commented Apr 25, 2023

Ok, am returning my attention to this for a week. Where are we at with this? Is it still a work in progress?

Yes, it is still work in progress. For the most part this one will be superseded by #111, which needs an additional macro to find HDF5 that was built by autotools. It finds HDF5 built with CMake.

@brtnfld
Copy link
Collaborator Author

brtnfld commented Apr 25, 2023

Closing, replaced by PR #111

@brtnfld brtnfld closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants