-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CMake testing #110
Enable CMake testing #110
Conversation
- Bug fix in the specification of the target_include_directories such it can find the created Fortran module file. - Implemented the option to specify the output file of the Fortran test program. - Implemented several tests for both the plugin as well as for for the library. The tests themselves are based on the existing Make tests.
- Implemented the proper logic for the cfp test. Be aware, this logic requires a recent update of ZFP library in which the cfp target is exposed by the ZFP CMake configuration file.
Addressed Windows warnings and compiling issues
- Define _GNU_SOURCE only if it is not defined yet. - Properly support building of the library and plugin using Microsoft Visual Studio. - Exclude certain tests when the compiler corresponds to some version of Microsoft Visual Compiler.
After setting HDF5_DIR and ZFP_DIR, creating a build subdirectory and running "CC=gcc FC=gfortran cmake -DCMAKE_INSTALL_PREFIX=/mnt/wrk/lrknox/h5z-zfp_install .." in the build directory (which succeeds), running either "make install" or running "cmake --build . --config Release" produced the following error: [100%] Linking C executable print_h5repack_farg This was with CMake 3.22.1 and GCC 10.2.0 modules on centOS7 (jelly). |
Probably need to add ${CMAKE_DL_LIBS} to target_link_libraries() |
Ok, am returning my attention to this for a week. Where are we at with this? Is it still a work in progress? |
Yes, it is still work in progress. For the most part this one will be superseded by #111, which needs an additional macro to find HDF5 that was built by autotools. It finds HDF5 built with CMake. |
Closing, replaced by PR #111 |
Enable CMake testing: