-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: (fix) MPI parallel HDF5 1.14.0 #97
Conversation
jwsblokland
commented
Jan 12, 2023
- The other day the HDF group has release HDF5 1.14.0. If the MPI parallel version of HDF5 1.14.0 is built using CMake then target MPI::MPI_C is required when using the target ${HDF5_LIBRARIES} in a CMake project like H5Z-ZFP. I have implemented finding the required MPI target in the case if HDF5 is parallel.
This pull request solves issue #98. @markcmiller86 Apparently, the Ubuntu test fails because certain url does not longer exist. I am not sure how and if I can fix it. |
- The other day the HDF group has release HDF5 1.14.0. If the MPI parallel version of HDF5 1.14.0 is built using CMake then target MPI::MPI_C is required when using the target ${HDF5_LIBRARIES} in a CMake project like H5Z-ZFP. I have implemented finding the required MPI target in the case if HDF5 is parallel.
5f710b0
to
1753649
Compare
@markcmiller86 I was able to figure it out the Ubuntu problem. Now everything works. |
I've got that fixed in #96 but haven't merged that yet and don't know if I actually will. You can go grab the fix there though. |
Has this been tested agains older HDF5 versions? I can't recall..what would happen if |
I tested both HDF5 1.12.1 and 1.14.0 and both of them work. Actually, HDF5 version 1.12.1 does not require MPI::MPI_C target. The current implementation always to try to find Currently, the CMake build configuration of H5Z-ZFP requires CMake 3.9 as a minimum version. For this minimum version 3.9 the CMake variable Furthermore, I also checked the case if |
For reference, see HDFGroup/hdf5#2404, HDFGroup/hdf5#2400 |
Reading the discussion HDFGroup/hdf5#2404 and HDFGroup/hdf5#2400, mentioned by @brtnfld we may want to specialize the implemented solution by only applying it for HDF5 1.14.0. Of course assuming that the bug only occurs in 1.14.0 and that implemented solution in PR HDFGroup/hdf5#2400 will be part of HDF5 1.14.1. |