Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build scripts for SYCL on Corona. #1254

Merged
merged 8 commits into from
Jun 27, 2022
Merged

Conversation

rchen20
Copy link
Member

@rchen20 rchen20 commented Apr 22, 2022

Summary

  • This PR is a refactor
  • It does the following:
    • Adds a build script for a custom SYCL compiler on Corona.

@@ -0,0 +1,32 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALCF directory is for scripts to use on Argonne machines. Corona is an LC machine. So it should go in the LC builds directory and have toss4 in the script name. Also, please update copyright header following the format of the others.

@artv3
Copy link
Member

artv3 commented Jun 20, 2022

@rhornung67 @rchen20 , I moved some files around and added some guards. I was able to build the code and run.

artv3
artv3 previously approved these changes Jun 20, 2022
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

rhornung67
rhornung67 previously approved these changes Jun 20, 2022

set(RAJA_COMPILER "RAJA_COMPILER_CLANG" CACHE STRING "")

set(CMAKE_CXX_COMPILER "clang++" CACHE PATH "")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artv3 @rhornung67 Should I hard-code this path to the installed compiler on corona (i.e. /usr/workspace/raja-dev/clang_sycl_hip_gcc10.2.1_rocm5.1.0/bin/clang++)? This would eliminate the need for the user to alter their $PATH.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would follow the way we do this in the other build scripts by having users provide version info. We may want to eventually have multiple versions available to compare. In other words have the host-config be generic and have the build script set path info based on the version info a user provides.

@rchen20
Copy link
Member Author

rchen20 commented Jun 20, 2022

@artv3 @rhornung67 Made some changes to the script to make it easier to use. Please take another look.

artv3
artv3 previously approved these changes Jun 20, 2022
@rchen20
Copy link
Member Author

rchen20 commented Jun 27, 2022

@rhornung67 If there are no other objections or comments, I'll merge this?

@rhornung67
Copy link
Member

Go for it.

@rchen20 rchen20 merged commit d3f6890 into develop Jun 27, 2022
@rchen20 rchen20 deleted the feature/chen59/syclcorona branch June 27, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants