-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build scripts for SYCL on Corona. #1254
Conversation
@@ -0,0 +1,32 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ALCF directory is for scripts to use on Argonne machines. Corona is an LC machine. So it should go in the LC builds directory and have toss4 in the script name. Also, please update copyright header following the format of the others.
@rhornung67 @rchen20 , I moved some files around and added some guards. I was able to build the code and run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments.
… feature/chen59/syclcorona
|
||
set(RAJA_COMPILER "RAJA_COMPILER_CLANG" CACHE STRING "") | ||
|
||
set(CMAKE_CXX_COMPILER "clang++" CACHE PATH "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artv3 @rhornung67 Should I hard-code this path to the installed compiler on corona
(i.e. /usr/workspace/raja-dev/clang_sycl_hip_gcc10.2.1_rocm5.1.0/bin/clang++
)? This would eliminate the need for the user to alter their $PATH
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would follow the way we do this in the other build scripts by having users provide version info. We may want to eventually have multiple versions available to compare. In other words have the host-config be generic and have the build script set path info based on the version info a user provides.
@artv3 @rhornung67 Made some changes to the script to make it easier to use. Please take another look. |
@rhornung67 If there are no other objections or comments, I'll merge this? |
Go for it. |
Summary