Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document kernel gpu indexing changes #1499

Merged
merged 7 commits into from
Jun 27, 2023
Merged

Document kernel gpu indexing changes #1499

merged 7 commits into from
Jun 27, 2023

Conversation

MrBurmark
Copy link
Member

@MrBurmark MrBurmark commented Jun 21, 2023 •
edited by rhornung67
Loading

Document changes in #1334

  • This PR is for documentation
  • It does the following (modify list as needed):
    • Adds documentation at the request of lots of people

Documentation for this branch is enabled in read the docs for reviewer inspection. The relevant changes are here: https://raja.readthedocs.io/en/documentation-burmark1-kernelgpuglobalindexing/sphinx/user_guide/feature/policies.html

@MrBurmark
Update docs for kernel/launch policies.
652d53d 
We have a large number of policies so only the basics are covered.
@MrBurmark MrBurmark mentioned this pull request Jun 21, 2023
Merged
artv3
artv3 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@artv3 artv3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this good, perhaps after the release we can revisit the matrix-multiplication example? I think we can benefit from using some of these new policies in particular for tutorial purposes.

rhornung67
rhornung67 reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested changes for clarification.

@MrBurmark @rhornung67
Apply suggestions from code review
3f41816 
Co-authored-by: Rich Hornung <hornung1@llnl.gov>
@MrBurmark MrBurmark enabled auto-merge June 26, 2023 22:42
@MrBurmark MrBurmark merged commit b119285 into develop Jun 27, 2023
15 checks passed
@MrBurmark MrBurmark deleted the documentation/burmark1/KernelGpuGlobalIndexing branch June 27, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhornung67 rhornung67 rhornung67 approved these changes

@artv3 artv3 artv3 approved these changes

@rchen20 rchen20 Awaiting requested review from rchen20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrBurmark @artv3 @rhornung67