Reproducer/nvidia/offset - (DO NOT MERGE) #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #478 +/- ##
=============================================
+ Coverage 98.576% 98.577% +0.001%
=============================================
Files 61 61
Lines 1194 1195 +1
=============================================
+ Hits 1177 1178 +1
Misses 17 17
Continue to review full report at Codecov.
|
rhornung67
reviewed
May 10, 2018
There was a problem hiding this comment.
@artv3 Did you document this issue on the COE compiler issue page, nvcc section?
|
@artv3 - do we need to keep this PR open? |
|
@davidbeckingsale , I am not sure. I shared the issue on the COE compiler issue page and with an NVIDIA rep. I can check with him. |
|
We don't need to delete the branch, but we can just close the PR. |
|
Oh gotcha. Sure we can close it. I can let him know it will still be there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducer for NVIDIA. We found a bug when views are used in the device with offset layouts. In particular the generated copy constructor does not actually copy-construct the object.
The follows compilers generate run time errors :
CUDA 8, 9.0.176, 9.0.184, 9.1.76, 9.1.85 .
In particular the following test fails /test/unit/cuda/test/test-cuda-forall-view.exe
By defining FIX_NVCC_BUG in nvidia-bug/include/RAJA/util/View.hpp we are able to fix the bug, i.e. specifying the copy constructor. Removing FIX_NVCC_BUG macro will cause run-time errors.
git clone -b reproducer/nvidia/offset https://github.com/LLNL/RAJA.git nvcc-bug
cd nvcc-bug
git submodule init && git submodule update
mkdir build
cmake -DENABLE_CUDA=On -DCUDA_TOOLKIT_ROOT_DIR=$(PATH_TO_CUDA) ../
make -j
./test/unit/cuda/test/test-cuda-forall-view.exe