Fix wrong style error for unwrapped commit message #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkpatch.sh style checker incorrectly flags commit description lines that are too long. The default 'git format-patch' output includes diff stats that checkpatch.pl is interpreting as part of the commit message. Add the 'git format-patch -p' option to generate plain diffs without diff stats.
dsikich
approved these changes
Dec 12, 2017
MichaelBrim
added a commit
to MichaelBrim/UnifyFS
that referenced
this pull request
Dec 4, 2018
# This is the 1st commit message: # This is a combination of 14 commits. # This is the 1st commit message: initial behavior debug # This is the commit message #2: fix int/long/size_t/off_t confusion # This is the commit message LLNL#3: more size_t fixes # This is the commit message LLNL#4: code rationalization # This is the commit message LLNL#5: debug logging # This is the commit message LLNL#6: more debugging # This is the commit message LLNL#7: more understanding # This is the commit message LLNL#8: more reasonable constant values # This is the commit message LLNL#9: zero buffers before use # This is the commit message LLNL#10: more cleanup and callocs # This is the commit message LLNL#11: append uid to runstate file # This is the commit message LLNL#12: create runstate file after MPI_Init # This is the commit message LLNL#13: simplify client context copy # This is the commit message LLNL#14: debug meta_batch_get # This is the commit message #2: sysio-writeread example improvements # This is the commit message LLNL#3: tons more understanding and size_t cleanup # This is the commit message LLNL#4: build fixes # This is the commit message LLNL#5: build fixes # This is the commit message LLNL#6: build fixes # This is the commit message LLNL#7: build fixes # This is the commit message LLNL#8: build fixes # This is the commit message LLNL#9: build fixes # This is the commit message LLNL#10: simplify lio_listio aiocb_list setup # This is the commit message LLNL#11: clean up mdhim range_server_bget leveldb code # This is the commit message LLNL#12: add server include path # This is the commit message LLNL#13: add common include path # This is the commit message LLNL#14: remove old macros # This is the commit message LLNL#15: build fixes # This is the commit message LLNL#16: fix value computed not used warning # This is the commit message LLNL#17: fix printf formats # This is the commit message LLNL#18: build fixes # This is the commit message LLNL#19: fix UNIFYCR_VAL_SZ definition # This is the commit message LLNL#20: fix mismatch between client and server read request structs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The checkpatch.sh style checker incorrectly flags
commit description lines that are too long. The default
'git format-patch' output includes diff stats that
checkpatch.pl is interpreting as part of the commit
message. Add the 'git format-patch -p' option to
generate plain diffs without diff stats.
Motivation and Context
False style warnings are no fun.
How Has This Been Tested?
Manually.
Types of changes
Checklist: