Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More warnings cleanup #1427

Merged
merged 3 commits into from
Sep 26, 2024
Merged

More warnings cleanup #1427

merged 3 commits into from
Sep 26, 2024

Conversation

publixsubfan
Copy link
Contributor

Summary

  • Modifies MDMapping::isPermutation to avoid warning about unsigned integer comparison
  • Add AXOM_HOST_DEVICE annotation to BivariateMap::iterator::value()

@publixsubfan publixsubfan added Core Issues related to Axom's 'core' component Slam Issues related to Axom's 'slam' component GPU Issues related to GPU development labels Sep 26, 2024
kennyweiss
kennyweiss approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @publixsubfan !

agcapps
agcapps approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@agcapps agcapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

rhornung67
rhornung67 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @publixsubfan

@rhornung67 rhornung67 merged commit b9cc160 into develop Sep 26, 2024
13 checks passed
@rhornung67 rhornung67 deleted the feature/yang39/warning-cleanup-2 branch September 26, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyweiss kennyweiss kennyweiss approved these changes

@rhornung67 rhornung67 rhornung67 approved these changes

@agcapps agcapps agcapps approved these changes

@bmhan12 bmhan12 bmhan12 approved these changes

@white238 white238 Awaiting requested review from white238

@BradWhitlock BradWhitlock Awaiting requested review from BradWhitlock

@gunney1 gunney1 Awaiting requested review from gunney1

Assignees
No one assigned
Labels
Core Issues related to Axom's 'core' component GPU Issues related to GPU development Slam Issues related to Axom's 'slam' component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@publixsubfan @kennyweiss @rhornung67 @agcapps @bmhan12