Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append -dirty to Git hashcode when working tree is dirty #445

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

joshessman-llnl
Copy link
Member

@joshessman-llnl joshessman-llnl commented Dec 22, 2020

This replaces rev-parse with describe, which was introduced in Git 2.4.12 (May 2017). Do we need to support versions of Git older than that?

@kennyweiss
Copy link
Member

@joshessman-llnl wrote:

This replaces rev-parse with describe, which was introduced in Git 2.4.12 (May 2017).
Do we need to support versions of Git older than that?

The change here is small enough that it seems like we should probably check the git version and use the appropriate command.

Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice change @joshessman-llnl, but since we're not requiring a specific version of git and this is a known issue that is easy to workaround, it seems to me that we should check the git version and use the appropriate command.

OTOH, if others feel that we do not need to support older git versions, then we should document the minimum supported version somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants