Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cuda driver cmake dependency #130

Closed

Conversation

MrBurmark
Copy link
Member

Find CUDAToolkit and depend on CUDA::cuda_driver.

Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MrBurmark . I assume you tested this in a RAJA build.

@MrBurmark
Copy link
Member Author

MrBurmark commented May 17, 2023

Looks like RAJA is going to have to find CUDAToolkit as well otherwise it doesn't know what CUDA::cuda_driver is.

@rhornung67
Copy link
Member

Looks like RAJA is going to have to find CUDAToolkit as well otherwise it doesn't know what CUDA::cuda_driver is.

Grrrf. Should we add that to Arturo's launch docs PR to minimize churn?

@MrBurmark
Copy link
Member Author

MrBurmark commented May 17, 2023

I'm afraid of how far this finding will have to go down the lib stack. Presumably, umpire, chai, and anyone else using camp may have to add this.

@rhornung67
Copy link
Member

Do we have to wait on BLT support to make it seamless?

@MrBurmark
Copy link
Member Author

MrBurmark commented May 17, 2023

I think so, but it doesn't sound like that's coming super soon.

@rhornung67
Copy link
Member

Chris said he is working on a BLT release. @white238 can you clarify whether the find cuda toolkit business will be available in that?

@MrBurmark
Copy link
Member Author

Closing this inadequate attempt to fix the config as we're going to revert the changes that necessitated this change #131.

@MrBurmark MrBurmark closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants