Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlink support 1.0 #1249

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Overlink support 1.0 #1249

merged 8 commits into from
Feb 5, 2024

Conversation

JustinPrivitera
Copy link
Member

Finished the last few things needed for Overlink support:

  • require matsets to be present to write overlink
  • convert data arrays to doubles since overlink does not support floats
  • remove warning saying overlink is not fully supported
  • update tests to add matsets where needed to make overlink save happy
  • verified that all files we write to overlink in tests pass Jeff's overlink file format validator

@cyrush cyrush merged commit 2aa7db4 into develop Feb 5, 2024
25 checks passed
@cyrush cyrush deleted the task/JustinPrivitera/02_02_24/overlink_progress branch February 5, 2024 21:08
@JustinPrivitera JustinPrivitera mentioned this pull request Feb 6, 2024
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrush cyrush cyrush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinPrivitera @cyrush