Silo I/O: Read All Kinds of Silo Data #1274
Conversation
JustinPrivitera
commented
Apr 18, 2024
JustinPrivitera
commented
- Enable reading of various kinds of silo data, so we are no longer restricted to multimeshes, multivars, multimats, etc.
- handle column major data for many cases
- handle min/max index for many cases
…main read function
|
TODO
|
This comment was marked as outdated.
This comment was marked as outdated.
| @@ -1781,12 +1786,60 @@ TEST(conduit_relay_io_silo, read_silo) | |||
| { | |||
| remove_path_if_exists(out_name + "_write_overlink"); | |||
| write_opts["file_style"] = "overlink"; | |||
| write_opts["ovl_topo_name"] = meshname; | |||
| write_opts["ovl_topo_name"] = meshname; // TODO do I even need this | |||
There was a problem hiding this comment.
Good Q: Does overlink ignore this?
There was a problem hiding this comment.
I think specifying the topo name for overlink is only necessary when there are multiple topos. Since we only read one topo there is only one to output, so I think this should be unnecessary.
There was a problem hiding this comment.
I'm going to merge this and tweak the tests later; there are other fixes to do in the tests.
There was a problem hiding this comment.
I was asking b/c these are write opts?
There was a problem hiding this comment.
/// In the overlink case...
/// 1) We have made the choice to output only ONE topology as a multimesh.
/// 2) mesh_name is ignored if provided and changed to "MMESH"
/// 3) ovl_topo_name is the name of the topo we are outputting. If it is not
/// provided, we choose the first topology in the blueprint.
There was a problem hiding this comment.
and yes those are write opts
| { | ||
| remove_path_if_exists(out_name + "_write_overlink"); | ||
| write_opts["file_style"] = "overlink"; | ||
| write_opts["ovl_topo_name"] = "MMESH"; // TODO do I even need this |
There was a problem hiding this comment.
Does overlink ignore this (it always has to be MMESH?)
There was a problem hiding this comment.
MMESH is actually the name of the blueprint topo in this case, since we read an overlink file into blueprint.
JustinPrivitera
deleted the
task/JustinPrivitera/03_28_24/arb_silo_files_exploration
branch
