Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify for structured options for adjsets #374

Merged
merged 23 commits into from
Apr 20, 2020
Merged

Conversation

nselliott
Copy link
Contributor

No description provided.

@cyrush
Copy link
Member

cyrush commented May 6, 2019

@nselliott we are getting close on this one - I exported this to VisIt and noticed gaps between the domains:

Screen Shot 2019-05-06 at 10 04 49 AM

Maybe a simple indexing fix is needed?

@gzagaris
Copy link
Member

gzagaris commented May 6, 2019

I've seen this before.

Perhaps, it is related to node-based partitioning vs. cell-based partitioning. Some codes may partition nodes (instead of cells) to different domains. Thereby, there exists a cell that spans two different domains, which, creates those gaps when visualized.

@cyrush
Copy link
Member

cyrush commented May 6, 2019

@gzagaris yes, I have seen things like this before as well.

this is an example mesh, i think this is just a simple index issue. Right now the set of domains aren't presenting topology covering those gaps.

@nselliott
Copy link
Contributor Author

@cyrush That should be fixed now--I had the wrong size for the uniform coordsets.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 86.07% when pulling 708d865 on nselliott:master into db0a528 on LLNL:master.

@nselliott
Copy link
Contributor Author

@cyrush This PR is updated to include refinement ratios in structured adjsets, to identify differing resolutions between neighboring domains.

@cyrush cyrush added this to the 0.6.0 milestone Jan 8, 2020
@cyrush
Copy link
Member

cyrush commented Apr 20, 2020

@nselliott took this for a spin, looks good to me.
I am going to merge and add some code to save the example in a follow on PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants