-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update uberenv #584
Update uberenv #584
Conversation
LGTM |
@@ -112,7 +126,7 @@ config: | |||
# of Spack. For filesystems that don't support locking, you should set | |||
# this to false and run one Spack at a time, but otherwise we recommend | |||
# enabling locks. | |||
locks: false | |||
locks: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry about this one being true, it has caused hangs in the past
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot of change with lock management is Spack since.
I would suggest giving it a chance. I’ve had issues with this not being set to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s is true that this has "only" be tested by me locally and in CI.
So I understand that merging this is less straight-forward than merging CI only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, lets keep them on
I guess you may actually need it for the CI workflows that have shared spack instances?
In the past locks weren't necessary and could be a barrier (hangs) for single install. But if we are going to use shared upstreams, we need them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conduit/scripts/ci/build-on-lc.sh
Line 39 in 9d654df
PREFIX="--prefix=${INSTALL_ROOT}_${SYS_TYPE}_${TOOLCHAIN}" |
Prefix still depends on the toolchain, I wanted to avoid concurrency at first, but it’s a potential optimization.
I am getting a source mirror up and running in #585, after this seems to be working, then I can try to help with updating uberenv. |
7a90e08
to
a5e808f
Compare
a5e808f
to
ab6831d
Compare
closing since #684 will accomplish this with uberenv as a submodule. |
It was decided that #517 should be split in two:
This PR updates Uberenv with a more recent version, fixing some bugs and allowing to get rid of "fake packages".