-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update uberenv #584
Closed
Closed
Update uberenv #584
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7932301
Update uberenv
adrienbernede 3d00d60
Updating spack config
adrienbernede 0c89ce9
Updating allowed failures with new results
adrienbernede f440e1b
Using a specific commit in Spack instead of a branch reference
adrienbernede 614098d
Fix mirror issue in uberenv (update)
adrienbernede 2c76686
Merge branch 'master' into feature/update-uberenv
adrienbernede 63f5616
Tentative fix for azure with new uberenv
adrienbernede 7f5e06d
Revert "Tentative fix for azure with new uberenv"
adrienbernede ab6831d
Enforcing compatible arch with gcc5
adrienbernede File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,12 @@ | ||
{ | ||
"package_name" : "conduit", | ||
"uberenv_package_name" : "uberenv-conduit", | ||
"spack_url": "https://github.com/alpine-DAV/spack", | ||
"spack_branch": "task/2019_11_update_ascent", | ||
"spack_activate" : {"py-numpy" : ["+python"], | ||
"py-sphinx": ["+python","+doc"], | ||
"package_version" : "master", | ||
"package_final_phase" : "configure", | ||
"package_source_dir" : "../..", | ||
"spack_url": "https://github.com/spack/spack", | ||
"spack_commit": "9d1f71e89f184d9b05f15ff81532aec460795fd0", | ||
"spack_activate" : {"py-numpy" : ["+python"], | ||
"py-sphinx": ["+python","+doc"], | ||
"py-mpi4py" : ["+python", "+mpi"], | ||
"py-sphinx-rtd-theme": ["+python","+doc"] } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry about this one being true, it has caused hangs in the past
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot of change with lock management is Spack since.
I would suggest giving it a chance. I’ve had issues with this not being set to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s is true that this has "only" be tested by me locally and in CI.
So I understand that merging this is less straight-forward than merging CI only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, lets keep them on
I guess you may actually need it for the CI workflows that have shared spack instances?
In the past locks weren't necessary and could be a barrier (hangs) for single install. But if we are going to use shared upstreams, we need them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conduit/scripts/ci/build-on-lc.sh
Line 39 in 9d654df
Prefix still depends on the toolchain, I wanted to avoid concurrency at first, but it’s a potential optimization.