Preserve existing inc_metrics in update_inclusive_columns #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilumsden
added
area-graphframe
|
I realized that this branch does not currently have additional unit tests to test the preservation of inclusive columns. |
ilumsden
added
status-work-in-progress
… update_inclusive_columns is called
… are no duplicates
… added back to inc_metrics after subgraph_sum
ilumsden
force-pushed
the
preserve_inc_update_inclusive
branch
from
fddb018
to
a6fd3a2
Compare
ilumsden
force-pushed
the
preserve_inc_update_inclusive
branch
from
a6fd3a2
to
1cfa613
Compare
ilumsden
added
status-ready-for-review
slabasan
reviewed
Feb 23, 2022
slabasan
reviewed
Feb 23, 2022
…he exclusive metric to 'line'
slabasan
requested changes
Feb 24, 2022
slabasan
added
status-revisions-needed
…ation feature's unit test
ilumsden
added
status-ready-for-review
slabasan
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to fix a bug in
GraphFrame.update_inclusive_columnsthat causes existing values inGraphFrame.inc_columnsto be dropped.As an example, consider a
GraphFramewith the following metrics:exc_metrics:["time"]inc_metrics:["foo"]Currently, after calling
update_inclusive_columns,inc_metricswill no longer contain"foo". Instead,inc_metricswill simply be["time (inc)"].This PR will extend
inc_metricsinstead of overriding. So, in the above example,inc_metricswill now be["foo", "time (inc)"].