Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve existing inc_metrics in update_inclusive_columns #18

Merged
merged 6 commits into from
Apr 27, 2022
Merged

Preserve existing inc_metrics in update_inclusive_columns #18

merged 6 commits into from
Apr 27, 2022

Commits on Feb 21, 2022

  1. Fixes a bug where existing value of inc_metrics is not preserved when… 

    … update_inclusive_columns is called
    @ilumsden
    ilumsden committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    36be110 View commit details
    Browse the repository at this point in the history

  2. Passes the new inclusive columns through set function to ensure there… 

    … are no duplicates
    @ilumsden
    ilumsden committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    7bb1456 View commit details
    Browse the repository at this point in the history

  3. Tweaks update_inclusive columns so that the old inclusive metrics are… 

    … added back to inc_metrics after subgraph_sum
    @ilumsden
    ilumsden committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    75f4703 View commit details
    Browse the repository at this point in the history

  4. Adds a unit test for the preservation of inclusive columns

    @ilumsden
    ilumsden committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    1cfa613 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Updates the 'preservation of inclusive columns' unit test to change t… 

    …he exclusive metric to 'line'
    @ilumsden
    ilumsden committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    a1d3fb6 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Removes unneeded checks of inc_metrics and exc_metrics in the preserv… 

    …ation feature's unit test
    @ilumsden
    ilumsden committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    3e40ba1 View commit details
    Browse the repository at this point in the history