-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve existing inc_metrics in update_inclusive_columns #18
Merged
slabasan
merged 6 commits into
LLNL:develop
from
TauferLab:preserve_inc_update_inclusive
Apr 27, 2022
Merged
Preserve existing inc_metrics in update_inclusive_columns #18
slabasan
merged 6 commits into
LLNL:develop
from
TauferLab:preserve_inc_update_inclusive
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized that this branch does not currently have additional unit tests to test the preservation of inclusive columns. |
… update_inclusive_columns is called
… are no duplicates
… added back to inc_metrics after subgraph_sum
fddb018
to
a6fd3a2
Compare
a6fd3a2
to
1cfa613
Compare
slabasan
reviewed
Feb 23, 2022
slabasan
reviewed
Feb 23, 2022
…he exclusive metric to 'line'
slabasan
requested changes
Feb 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove if statements in unit test
…ation feature's unit test
slabasan
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-graphframe
Issues and PRs involving Hatchet's core GraphFrame datastructure and associated classes
priority-normal
Normal priority issues and PRs
status-ready-for-review
This PR is ready to be reviewed by assigned reviewers
type-bug
Identifies bugs in issues and identifies bug fixes in PRs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to fix a bug in
GraphFrame.update_inclusive_columns
that causes existing values inGraphFrame.inc_columns
to be dropped.As an example, consider a
GraphFrame
with the following metrics:exc_metrics
:["time"]
inc_metrics
:["foo"]
Currently, after calling
update_inclusive_columns
,inc_metrics
will no longer contain"foo"
. Instead,inc_metrics
will simply be["time (inc)"]
.This PR will extend
inc_metrics
instead of overriding. So, in the above example,inc_metrics
will now be["foo", "time (inc)"]
.