Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PNNL CI #526

Merged
merged 5 commits into from Aug 5, 2022
Merged

Fix PNNL CI #526

merged 5 commits into from Aug 5, 2022

Conversation

cameronrutherford
Copy link
Collaborator

PR to test out newly enabled pipelines and to push environment updates.

@cameronrutherford
Copy link
Collaborator Author

PNNL CI is functional again. I will add Newell to this pipeline next, followed by trying to debug on Incline.

For some reason the spack builds got further but still failed for the same reason, and so I am disabling those again for the moment.

@cameronrutherford cameronrutherford mentioned this pull request Aug 4, 2022
@cameronrutherford
Copy link
Collaborator Author

spack/spack#31941 - used this PR to file a spack issue about the failing CI pipelines

@cameronrutherford
Copy link
Collaborator Author

@nychiang @pelesh this is currently passing CI on all PNNL platforms, so you can merge if you want.

I want to get an incline build working and have that CI runner passing at PNNL, and so if we can wait on merging this until I have had some time to debug that, I would appreciate it. I can always do that in another PR though...

@pelesh pelesh changed the title Draft: Fix PNNL CI Fix PNNL CI Aug 5, 2022
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, all tests pass. @nychiang, @cnpetra this is ready to merge.

@pelesh pelesh merged commit 18601eb into amd_direct_solver Aug 5, 2022
@nychiang
Copy link
Collaborator

nychiang commented Aug 5, 2022

LGTM. Thanks! @pelesh @cameronrutherford

cnpetra pushed a commit that referenced this pull request Aug 8, 2022
* Working Ginkgo direct solver on AMD

* fix build failure without ma57

* minor corrections

* Update Ascent CI script to use ginkgo@ea106a945a390a1580baee4648c19ca2b665acdf

* Add ginkgo_exec option to choose the hardware architecture the Ginkgo solver is run on.

* Add tests for CUDA and HIP backends

* Fix typo

* Fix PNNL CI (#526)

* Update marianas variables and add spack.yaml.

* Add debugging lines for failing spack build.

* Fix syntax error.

* Update Newell variables and re-enable CI.

* Fix bugs in newell variables.

Fixup.

* Disable ginkgo+cuda test on Marianas.

* Bugfix test config on marianas.

* Final attempt at disablingng specific tests.

Co-authored-by: Nicholson Koukpaizan <koukpaizannk@ornl.gov>
Co-authored-by: Cameron Rutherford <robert.rutherford@pnnl.gov>
nychiang pushed a commit that referenced this pull request Sep 30, 2022
* Working Ginkgo direct solver on AMD

* fix build failure without ma57

* minor corrections

* Update Ascent CI script to use ginkgo@ea106a945a390a1580baee4648c19ca2b665acdf

* Add ginkgo_exec option to choose the hardware architecture the Ginkgo solver is run on.

* Add tests for CUDA and HIP backends

* Fix typo

* Fix PNNL CI (#526)

* Update marianas variables and add spack.yaml.

* Add debugging lines for failing spack build.

* Fix syntax error.

* Update Newell variables and re-enable CI.

* Fix bugs in newell variables.

Fixup.

* Disable ginkgo+cuda test on Marianas.

* Bugfix test config on marianas.

* Final attempt at disablingng specific tests.

Co-authored-by: Nicholson Koukpaizan <koukpaizannk@ornl.gov>
Co-authored-by: Cameron Rutherford <robert.rutherford@pnnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants