Condensed/normaleqn linear system without CUDA/RAJA #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is kosher. In the PR diff, I do not see how/if MA57 and/or xdycyd gets picked up when RAJA/HIOP_SPARSE is not present in the build... but I guess that logic is already in place |
fritzgoebel
reviewed
Oct 14, 2022
| @@ -40,10 +42,6 @@ set(hiopOptimization_INTERFACE_HEADERS | |||
| hiopResidual.hpp | |||
| ) | |||
|
|
|||
| if(HIOP_USE_RAJA) | |||
| list(APPEND hiopOptimization_SPARSE_SRC hiopKKTLinSysSparseCondensed.cpp hiopKKTLinSysSparseNormalEqn.cpp) | |||
| endif() | |||
There was a problem hiding this comment.
For me this change leads to error: 'hiopVectorRajaPar' does not name a type, e.g. in line 175 of src/Optimization/hiopKKTLinSysSparseCondensed.cpp when building with Ginkgo and CUDA but without RAJA.
There was a problem hiding this comment.
Thank you! I was having a similar concern re: building w/o RAJA. Nai-Yuan and I will meet today and will address this.
There was a problem hiding this comment.
I think the issue has been fixed, it would be great if you could confirm
cnpetra
approved these changes
Oct 17, 2022
fritzgoebel
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condensed/normaleqn linear system should work on CPU, using MA57 as the backend linear solver.
In the current
developbranch, PR #549 changed the CI behaviors when neither RAJA nor CUDA is defined, i.e., hiop will switchCondensed/normaleqntoxycydand solves the problem without any warning. In addition, #549 compiles the cpp files for condensed/normaleqn system only if raja is defined (see here).Since condensed/normaleqn system should work without raja, I correct the above issues in this PR.
This PR also guarantees the feature @fritzgoebel introduced in #549, i.e., enable cuda build without raja.
I believe now we can compile hiop with cuda and ginkgo, but without raja.