Update the comments in hiopVector classes
#592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnpetra
reviewed
Feb 9, 2023
| @@ -294,28 +294,6 @@ void hiopVectorRaja<MEM, POL>::copyFrom(const double* local_array) | |||
| } | |||
| } | |||
|
|
|||
| /// @brief Copy from vec the elements specified by the indices in index_in_src. | |||
| template<class MEM, class POL> | |||
| void hiopVectorRaja<MEM, POL>::copy_from(const hiopVector& vec, const hiopVectorInt& index_in_src) | |||
There was a problem hiding this comment.
I am wondering why the implementation of two copy_from methods was removed...
There was a problem hiding this comment.
cnpetra
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hiopVector.hpp(the abstract class).copy_from(const hiopVector& vec, const hiopVectorInt& index_in_src)(keep
copy_from_indexes(const hiopVector& src, const hiopVectorInt& index_in_src);)CLOSE #576