Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU linear solver interface #650

Merged
merged 12 commits into from
Aug 16, 2023
Merged

GPU linear solver interface #650

merged 12 commits into from
Aug 16, 2023

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Aug 11, 2023 •
edited

This PR creates linear solver interface where ReSolve linear solver can receive data on both CPU and GPU, based on user selection.

@pelesh pelesh added enhancement sparse-develop Issues and PRs pertaining to development of branch sparse-develop solver options deals with options for the algorithm and solver device computations labels Aug 11, 2023
@pelesh pelesh marked this pull request as draft August 11, 2023 16:47
@pelesh pelesh changed the title Draft: GPU linear solver interface GPU linear solver interface Aug 11, 2023
@pelesh pelesh marked this pull request as ready for review August 14, 2023 18:15
@pelesh
Copy link
Collaborator Author

pelesh commented Aug 15, 2023

CC @cameronrutherford @ryandanehy

kswirydo
kswirydo approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@kswirydo kswirydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run it on Ascent with exago, it works as intended.

nychiang
nychiang approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@nychiang nychiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment.

src/LinAlg/ReSolve/RefactorizationSolver.cpp Outdated Show resolved Hide resolved
cnpetra
cnpetra approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@cnpetra cnpetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this worked out as expected with the cuda backend.

@cnpetra cnpetra merged commit 4b231f7 into develop Aug 16, 2023
7 checks passed
@pelesh pelesh deleted the remove-resolvegpu-dev branch August 16, 2023 22:53
@pelesh pelesh mentioned this pull request Aug 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kswirydo kswirydo kswirydo approved these changes

@cnpetra cnpetra cnpetra approved these changes

@nychiang nychiang nychiang approved these changes

Assignees
No one assigned
Labels
device computations enhancement solver options deals with options for the algorithm and solver sparse-develop Issues and PRs pertaining to development of branch sparse-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pelesh @kswirydo @cnpetra @nychiang