Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds code coverage through Codecov #139

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

ilumsden
Copy link
Collaborator

This PR adds code coverage to our unit testing using Codecov.

@ilumsden ilumsden self-assigned this Feb 28, 2024
@ilumsden ilumsden added area-ci Issues and PRs related to Thicket's continuous integration area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs status-work-in-progress PR is currently being worked on type-feature Requests for new features or PRs which implement new features labels Feb 28, 2024
@ilumsden ilumsden marked this pull request as ready for review May 9, 2024 19:13
@ilumsden ilumsden requested a review from pearce8 May 9, 2024 19:13
@ilumsden ilumsden added status-ready-for-review This PR is ready to be reviewed by assigned reviewers and removed status-work-in-progress PR is currently being worked on labels May 9, 2024
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ilumsden
Copy link
Collaborator Author

ilumsden commented May 9, 2024

@pearce8 I've gotten the integration with codecov working, so this PR is now ready for review. You can see the codecov reports at the following links:

The badge in the README will show the coverage for the develop branch. As a result, it will not start working until after this PR is merged.

Finally, I've enabled Codecov's "comment" feature, which creates comments in PR like the one's above. For other PRs, these comments will explain how code coverage will change as a result of the PR. There is supposed to only be one message per PR. I think the multiple comment thing might just be a result of me messing around with codecov so much, so I personally don't think that's a problem at this point.

@pearce8 pearce8 merged commit db283eb into LLNL:develop May 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ci Issues and PRs related to Thicket's continuous integration area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants