Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second attempt at adding Codecov support #161

Merged
merged 4 commits into from
May 14, 2024

Conversation

ilumsden
Copy link
Collaborator

This is the second attempt at adding Codecov support. The contents of this PR are primarily the same as #139. The only addition is that this PR adds the Codecov token so that uploads are supported outside of PRs.

@ilumsden ilumsden added area-ci Issues and PRs related to Thicket's continuous integration priority-normal Normal priority issues and PRs status-work-in-progress PR is currently being worked on type-feature Requests for new features or PRs which implement new features labels May 13, 2024
@ilumsden ilumsden requested a review from pearce8 May 13, 2024 17:25
@ilumsden ilumsden self-assigned this May 13, 2024
@ilumsden ilumsden marked this pull request as ready for review May 13, 2024 17:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@e107964). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #161   +/-   ##
==========================================
  Coverage           ?   76.72%           
==========================================
  Files              ?       52           
  Lines              ?     3442           
  Branches           ?        0           
==========================================
  Hits               ?     2641           
  Misses             ?      801           
  Partials           ?        0           

@ilumsden ilumsden added status-ready-for-review This PR is ready to be reviewed by assigned reviewers and removed status-work-in-progress PR is currently being worked on labels May 13, 2024
@pearce8 pearce8 merged commit 153dbf0 into LLNL:develop May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ci Issues and PRs related to Thicket's continuous integration priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants