Umap multi-region support #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Replaced spindle log with one based on Umpire
Installing Store.hpp in correct location.
maintain umapsort in umap-apps.
mayagokhale
reviewed
Jun 4, 2019
mayagokhale
reviewed
Jun 5, 2019
| #ifndef UMAP_RO_MODE | ||
| page_address | ||
| #endif | ||
| ) |
There was a problem hiding this comment.
The way I'm reading this, it will be void * followed by a right paren if it is read only mode. Is that what is intended?
There was a problem hiding this comment.
Correct. This is one way (perhaps not the best) to prevent compilation warnings of unused arguments when both type and argument are specified when the argument is not used. Specifying just the type maintains the signature, but no longer produces warnings when the arguments are ifdefed out in the implementation.
mayagokhale
reviewed
Jun 5, 2019
| #ifndef UMAP_RO_MODE | ||
| page_address | ||
| #endif | ||
| ) |
There was a problem hiding this comment.
Same as previous comment about the void * (
mayagokhale
reviewed
Jun 5, 2019
mayagokhale
reviewed
Jun 5, 2019
mayagokhale
previously approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update to umap including:
The API has also changed slightly and there is an associated umap-apps PR on the way as well.