Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utilization API to build on cpu-only systems, rename API to be generic #525

Merged
merged 11 commits into from
Mar 11, 2024

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Mar 7, 2024

Description

Fixes #518

To Do:

  • CPU-only build utilization numbers
  • Check for platform and call the GPU function if available
  • Rename the API from variorum_get_node_utilization_json to variorum_get_utilization_json
  • Remove the variorum_get_gpu_utilization_json API
  • Check if gpu_utilization is also removed from docs

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

  • Lassen-gpu-only
  • Lassen-cpu-only
  • Lassen-both
  • Corona-gpu-only
  • folsom
  • thompson
  • comus
  • rhetoric
  • Juno r2

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

@tpatki tpatki changed the title Updaet utilization API to build on cpu-only systems Update utilization API to build on cpu-only systems Mar 7, 2024
@tpatki tpatki changed the title Update utilization API to build on cpu-only systems Update utilization API to build on cpu-only systems, rename API to be generic Mar 9, 2024
@tpatki tpatki added status-work-in-progress In progress, not ready to merge. area-feature-support labels Mar 9, 2024
@slabasan slabasan added status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch and removed status-work-in-progress In progress, not ready to merge. labels Mar 11, 2024
@tpatki tpatki merged commit d3f847b into dev Mar 11, 2024
15 checks passed
@slabasan slabasan deleted the fix_util_on_cpus branch March 12, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-feature-support status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_node_utilization_json API needs to work correctly across CPU-only builds
2 participants