Update powmon to report utilization in addition to power. #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Merge remote-tracking branch 'origin/dev' into powmon_power_utilization
tpatki
added
status-work-in-progress
tpatki
added
status-ready-for-review
10 tasks
tpatki
added
status-ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #474 from @altahat2003.
Updated powmon to include node utilization, so that users can collect power and utilization data in parallel and output that in the file.
This PR depends on #431 that has now been merged.
Fixes #462.
Will need to be merged in after Mega Merge: Add new JSON GPU get power API, make Node-level get power JSON API nested, enable multi-platform build #490, as the API for powmon will change.
Note: Currently, the utilization API is designed for node-level and not supported on the CPU-only build (see get_node_utilization_json API needs to work correctly across CPU-only builds #518 and Update utilization API to build on cpu-only systems, rename API to be generic #525). We will be able to support the CPU-only sampling after we add support for that both in the utilization API and in powmon to parse the nested objects with variable entries appropriately, so we will merge this after Update utilization API to build on cpu-only systems, rename API to be generic #525.
To do:
-uoption should create a new file with utilization data (power data still being written out to existing file)Type of change
How Has This Been Tested?
Checklist:
./scripts/check-code-format.shand confirm my code code follows the style guidelines of variorum-DENABLE_WARNINGS=ON)Thank you for taking the time to contribute to Variorum!