Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maass eigenvalues shifted #2647

Closed
edgarcosta opened this issue Oct 8, 2018 · 14 comments
Closed

Maass eigenvalues shifted #2647

edgarcosta opened this issue Oct 8, 2018 · 14 comments
Labels
good to go Ready to implement -- the desired change is clearly defined and agreed Maass Maass waveforms production issue Problem currently impacting www.lmfdb.org
Milestone

Comments

@edgarcosta
Copy link
Member

Some forms display the eigenvalues shifted, e.g.:
http://www.lmfdb.org/ModularForm/GL2/Q/Maass/54104e8dacf756699fe0830c
vs
http://www.lmfdb.org/L/ModularForm/GL2/Q/Maass/54104e8dacf756699fe0830c/

@edgarcosta edgarcosta added the Maass Maass waveforms label Oct 8, 2018
@davidfarmer
Copy link
Member

davidfarmer commented Oct 8, 2018 via email

@edgarcosta
Copy link
Member Author

edgarcosta commented Oct 8, 2018

I should have been clearer.

I'm referring to the fact that in the Maass Form page we display,
c_0 = 1
c_1 = 0.7071067
c_2 = 1.1982127
c_3 = 0.5
c_4 = -0.2131064

while, I believe we wanted to display:
c_1 = 1
c_2 = 0.7071067
c_3 = 1.1982127
c_4 = 0.5
c_5 = -0.2131064

@davidfarmer
Copy link
Member

davidfarmer commented Oct 8, 2018 via email

@AndrewVSutherland AndrewVSutherland added this to the v1.1.1 milestone May 28, 2019
@AndrewVSutherland AndrewVSutherland added good to go Ready to implement -- the desired change is clearly defined and agreed production issue Problem currently impacting www.lmfdb.org labels Dec 14, 2019
@AndrewVSutherland
Copy link
Member

Looking at the level 2 forms I think the issue arises when the coefficients are stored in the mwf_forms table, see https://www.lmfdb.org/api/mwf_forms/?Level=2, What's weird is that the data looks consistent with many of the level 1 forms that have coefficients in mwf_forms, see https://www.lmfdb.org/api/mwf_forms/?Level=1, and these forms appear to display correctly.

@rbommel You looked at the relevant code most recently I think, any ideas?

@rbommel
Copy link
Contributor

rbommel commented Dec 14, 2019

Yes, my code couldn't find these coefficients due to a rounding error. I fixed this now and made a pull request for that. For some reason the coefficients of this particular form seemed to be stored multiple times in the database. As usual, I have no idea why it is like this. If you download the coefficients, you just get the raw data which I retrieve from the database.

@AndrewVSutherland
Copy link
Member

AndrewVSutherland commented Dec 14, 2019

@rbommel But does that explain why the coefficient display on http://www.lmfdb.org/ModularForm/GL2/Q/Maass/54104e8dacf756699fe0830c is shifted by 1? On your PR they still look shifted.

Also, it looks like your PR has a merge conflict.

@rbommel
Copy link
Contributor

rbommel commented Dec 14, 2019

Strange, when I run it here, I get 'c(0) = 0' now. The reason why it is shifted, is because the coefficients are stored wrongly in mwf_forms apparently (if we believe @edgarcosta). In mwf_coeffs the first coefficient is a 0.

Yes, it told me about this conflict, but Github told me not to worry about it, so I didn't.

@AndrewVSutherland
Copy link
Member

@rbommel Never mind, you are right it is fixed in your PR (I must have checkout out the wrong branch).

The merge conflict needs to be resolved before we can merge your PR, and I'd rather not do that by hand. Given how small and localized the change is, I might suggest getting your master up to date (pull from upstream), creating a new branch, and re implementing your more recent edits (possibly by copy and paste, but you'll want to be careful -- there is a reason github is complaining, possibly because a change you made in your last PR to the same section of code is not reflected in this PR).

@rbommel
Copy link
Contributor

rbommel commented Dec 14, 2019

Okay, somebody seems to have added some parenthesis around a print statement. I just left them there. Should be fine now.

@AndrewVSutherland
Copy link
Member

Fixed via #3536, thanks @rbommel !

@edgarcosta
Copy link
Member Author

edgarcosta commented Dec 15, 2019 via email

@davidfarmer
Copy link
Member

davidfarmer commented Dec 15, 2019 via email

@AndrewVSutherland
Copy link
Member

@edgarcosta Did you notice any pages where c(0) != 0? In most cases (and certainly in the case of http://www.lmfdb.org/ModularForm/GL2/Q/Maass/54104e8dacf756699fe0830c), c(0) is not even stored. Or are you suggesting c(0) should not be displayed at all? (if the latter I agree, but I don't think we should be investing any time any energy on improving the current UI, since the plan is to completely replace it, my only goal for 1.1.1 is to fix or hide anything that simply does not work or is mathematically incorrect (#2645, #2576, #2647, #2688, #2950, #3372 all fall into this category).

Having said that, if it is easy to do and someone is motivated to do it, I would be happy to see the c(0)=0 line go away.

@edgarcosta
Copy link
Member Author

edgarcosta commented Dec 16, 2019

@AndrewVSutherland, just confirming that c(0) = 0 is what I expect, instead of what we displayed before http://prod.lmfdb.xyz/ModularForm/GL2/Q/Maass/54104e8dacf756699fe0830c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good to go Ready to implement -- the desired change is clearly defined and agreed Maass Maass waveforms production issue Problem currently impacting www.lmfdb.org
Projects
None yet
Development

No branches or pull requests

4 participants