Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMF: added base change and CM as search parameter #2198

Merged
merged 2 commits into from
Jul 21, 2017

Conversation

sanni85
Copy link
Contributor

@sanni85 sanni85 commented Jul 20, 2017

Added base change and CM as search parameter.
Added tests for this too.

check here:
/ModularForm/GL2/TotallyReal/
/ModularForm/GL2/TotallyReal/?start=0&field_label=&deg=5&disc=&cm=include&bc=exclude&count=100

The knowls for CM and base change need to be written, but I think @jvoight is going to do that.
Issues #1975 #1972 could be closed.

@JohnCremona
Copy link
Member

Good!
Small point: in the tags it's enough to have the word 'selected' in the one you want to preselect, it is redundant to put 'selected="yes"', and I think clearer not too.
On the main browse page there's now a single column of 9 boxes. Time to make into 2 columns? And in the search again section, instead of 3 rows of 3 you could have only 2 rows.
Incidentally do we have any HMFs not of parallel weight 2? I found none by searching but perhaps I was doing it wrongly. If only have weight 2 the weight search box could be commented out.

@sanni85
Copy link
Contributor Author

sanni85 commented Jul 20, 2017

Take a look now. I have followed your advice more or less: I decided to make two section in the main browse page, one for the base field and one for the form. The part for the form has two columns. The search page result has 3 rows, the last only with the max number of results.

I have cleaned up the 'selected="yes"' and also from where I copied it....(that is the reason why you see changes in elliptic curves files).

For the weight, I think that @jvoight may have something to say.

@JohnCremona
Copy link
Member

Thanks! Layout is better. I'm sorry I gave you more work to do including changing code I wrote to matc my recommendations... I only recently saw that the 'selected ' tag could be simplified but never was organised enough to make changes except in the files I was working on.
@jvoight what about the weights? We do only have parallel weight 2 forms in the database, and while that remains the case it seems misleading to allow it as a search field -- the only effect would ever be to reduce the number of hits to zero! I would only comment out the boxes, in case of future expansion.

That's a separate issue though so I will merge this one now.

@JohnCremona JohnCremona merged commit e4e15b6 into LMFDB:master Jul 21, 2017
@jvoight
Copy link
Member

jvoight commented Jul 21, 2017

I remain optimistic that we will have higher weight forms at some point in the future, so I'd rather just leave it as is. JV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants